LeetCode sulla sottostringa palindromica più lunga in Python
Questa è una domanda di programmazione di LeetCode :
Data una stringa s, restituisce la sottostringa palindromica più lunga in s.
Esempio 1:
Input: s = "babad" Output: "bab" Nota: anche "aba" è una risposta valida.
Di seguito è riportato il mio codice che non supera il seguente input a causa di "Time Limit Exceeded":
""
class Solution(object):
def longestPalindrome(self, s):
"""
:type s: str
:rtype: str
"""
if len(s) == 0:
return None
if len(s) == 1:
return s
P = [[False]*len(s) for i in range(len(s))]
for i in range(len(s)):
P[i][i] = True
for i in range(len(s)-1):
P[i][i+1] = (s[i]==s[i+1])
for s_len in range(3,len(s)+1):
for i in range(len(s)+1-s_len):
P[i][i+s_len-1] = P[i+1][i+s_len-2] and (s[i]==s[i+s_len-1])
ip = 0
jp = 0
max_len = 1
for i in range(len(s)):
for j in range(len(s)):
if P[i][j] and j+1-i > max_len:
max_len = j+1-i
ip = i
jp = j
continue
return s[ip:jp+1]
Stavo cercando di seguire il seguente approccio descritto nella soluzione del sito. Qualcuno potrebbe aiutarmi a vedere come rendere il mio codice più efficiente?
Risposte
Dichiarazione di non responsabilità: non è un revisore del codice
Ecco però alcuni brevi commenti:
- Stai girando anche se due volte.
- Questo lo renderebbe forza bruta.
- La forza bruta di solito fallisce per alcune domande medio-difficili su LeetCode.
Soluzione alternativa
- Qui faremo un ciclo una volta:
class Solution:
def longestPalindrome(self, s):
if len(s) < 1:
return s
def isPalindrome(left, right):
return s[left:right] == s[left:right][::-1]
left, right = 0, 1
for index in range(1, len(s)):
if index - right > 0 and isPalindrome(index - right - 1, index + 1):
left, right = index - right - 1, right + 2
if index - right >= 0 and isPalindrome(index - right, index + 1):
left, right = index - right, right + 1
return s[left: left + right]
La tua soluzione
- Ho appena testato la tua soluzione (passa marginalmente):
class Solution(object):
def longestPalindrome(self, s):
"""
:type s: str
:rtype: str
"""
if len(s) < 1:
return s
P = [[False] * len(s) for i in range(len(s))]
for i in range(len(s)):
P[i][i] = True
for i in range(len(s) - 1):
P[i][i + 1] = (s[i] == s[i + 1])
for s_len in range(3, len(s) + 1):
for i in range(len(s) + 1 - s_len):
P[i][i + s_len - 1] = P[i + 1][i + s_len - 2] and (s[i] == s[i + s_len - 1])
ip = 0
jp = 0
max_len = 1
for i in range(len(s)):
for j in range(len(s)):
if P[i][j] and j + 1 - i > max_len:
max_len = j + 1 - i
ip = i
jp = j
continue
return s[ip:jp + 1]
Poiché l'autonomia è elevata, è possibile che a volte fallisca.
Immagino che LeetCode abbia un limite di tempo per ogni problema, forse 10 secondi sarebbe il limite per questo problema specifico.
Probabilmente in base alla geolocalizzazione / ora, anche il runtime sarebbe diverso.
Solo un po 'più di ottimizzazione:
- Si prega di vedere questa riga
for j in range(i + 1, len(s))::
class Solution(object):
def longestPalindrome(self, s):
"""
:type s: str
:rtype: str
"""
if len(s) < 1:
return s
P = [[False] * len(s) for _ in range(len(s))]
for i in range(len(s)):
P[i][i] = True
for i in range(len(s) - 1):
P[i][i + 1] = (s[i] == s[i + 1])
for s_len in range(3, len(s) + 1):
for i in range(len(s) + 1 - s_len):
P[i][i + s_len - 1] = P[i + 1][i + s_len - 2] and (s[i] == s[i + s_len - 1])
ip = 0
jp = 0
max_len = 1
for i in range(len(s)):
for j in range(i + 1, len(s)):
if P[i][j] and j + 1 - i > max_len:
max_len = j + 1 - i
ip = i
jp = j
continue
return s[ip:jp + 1]
Si riduce di circa 1 secondo ma ancora non va bene.
Sono sicuro che ci sono più modi per ottimizzare.
Aspettare un po! Ci sono buoni revisori Python qui. Probabilmente ti aiuterebbe.
Con alcuni commenti:
class Solution:
def longestPalindrome(self, s):
if len(s) < 1:
return s
def isPalindrome(left, right):
return s[left:right] == s[left:right][::-1]
# We set the left pointer on the first index
# We set the right pointer on the second index
# That's the minimum true palindrome
left, right = 0, 1
# We visit the alphabets from the second index forward once
for index in range(1, len(s)):
# Here we move the right pointer twice and once checking for palindromeness
# We boundary check using index - right, to remain positive
if index - right > 0 and isPalindrome(index - right - 1, index + 1):
print(f"Step {index - 1}: Left pointer is at {index - right - 1} and Right pointer is at {index + 1}")
print(f"Palindromeness start: {index - right - 1} - Palindromeness end: {index + 1}")
print(f"Window length: {right}")
print(f"Before: Left is {left} and Right is {left + right}")
left, right = index - right - 1, right + 2
print(f"After: Left is {left} and Right is {left + right}")
print(f"String: {s[left: left + right]}")
print('#' * 50)
if index - right >= 0 and isPalindrome(index - right, index + 1):
print(f"Step {index - 1}: Left pointer is at {index - right} and Right pointer is at {index + 1}")
print(f"Palindromeness start: {index - right - 1} - Palindromeness end: {index + 1}")
print(f"Window length: {right + 1}")
print(f"Before: Left is {left} and Right is {left + right}")
left, right = index - right, right + 1
print(f"After: Left is {left} and Right is {left + right}")
print(f"String: {s[left: left + right]}")
print('#' * 50)
return s[left: left + right]
Solution().longestPalindrome("glwhcebdjbdroiurzfxxrbhzibilmcfasshhtyngwrsnbdpzgjphujzuawbebyhvxfhtoozcitaqibvvowyluvdbvoqikgojxcefzpdgahujuxpiclrrmalncdrotsgkpnfyujgvmhydrzdpiudkfchtklsaprptkzhwxsgafsvkahkbsighlyhjvbburdfjdfvjbaiivqxdqwivsjzztzkzygcsyxlvvwlckbsmvwjvrhvqfewjxgefeowfhrcturolvfgxilqdqvitbcebuooclugypurlsbdfquzsqngbscqwlrdpxeahricvtfqpnrfwbyjvahrtosovsbzhxtutyfjwjbpkfujeoueykmbcjtluuxvmffwgqjgrtsxtdimsescgahnudmsmyfijtfrcbkibbypenxnpiozzrnljazjgrftitldcueswqitrcvjzvlhionutppppzxoepvtzhkzjetpfqsuirdcyqfjsqhdewswldawhdyijhpqtrwgyfmmyhhkrafisicstqxokdmynnnqxaekzcgygsuzfiguujyxowqdfylesbzhnpznayzlinerzdqjrylyfzndgqokovabhzuskwozuxcsmyclvfwkbimhkdmjacesnvorrrvdwcgfewchbsyzrkktsjxgyybgwbvktvxyurufsrdufcunnfswqddukqrxyrueienhccpeuqbkbumlpxnudmwqdkzvsqsozkifpznwapxaxdclxjxuciyulsbxvwdoiolgxkhlrytiwrpvtjdwsssahupoyyjveedgqsthefdyxvjweaimadykubntfqcpbjyqbtnunuxzyytxfedrycsdhkfymaykeubowvkszzwmbbjezrphqildkmllskfawmcohdqalgccffxursvbyikjoglnillapcbcjuhaxukfhalcslemluvornmijbeawxzokgnlzugxkshrpojrwaasgfmjvkghpdyxt")
Stampe:
Step 18: Left pointer is at 18 and Right pointer is at 20
Palindromeness start: 17 - Palindromeness end: 20
Window length: 2
Before: Left is 0 and Right is 1
After: Left is 18 and Right is 20
String: xx
##################################################
Step 25: Left pointer is at 24 and Right pointer is at 27
Palindromeness start: 23 - Palindromeness end: 27
Window length: 3
Before: Left is 18 and Right is 20
After: Left is 24 and Right is 27
String: ibi
##################################################
Step 462: Left pointer is at 460 and Right pointer is at 464
Palindromeness start: 459 - Palindromeness end: 464
Window length: 4
Before: Left is 24 and Right is 27
After: Left is 460 and Right is 464
String: pppp
##################################################